Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close src once recording has stopped #740

Merged
merged 2 commits into from
Jul 31, 2024
Merged

close src once recording has stopped #740

merged 2 commits into from
Jul 31, 2024

Conversation

frostbyte73
Copy link
Member

This way the recording status on the room doesn't lag behind while waiting for files to upload

@frostbyte73 frostbyte73 requested a review from a team as a code owner July 30, 2024 17:48
@frostbyte73 frostbyte73 requested a review from lukasIO July 30, 2024 18:20
lukasIO
lukasIO approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm!

@frostbyte73 frostbyte73 merged commit b9f213f into main Jul 31, 2024
8 checks passed
@frostbyte73 frostbyte73 deleted the src-and-sinks branch July 31, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasIO lukasIO lukasIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frostbyte73 @lukasIO